Audit log issue in before save hook

Hello Dhiraj Chaudhari, 

Thanks for reaching out. 
Regarding your scenario, is this Save action coming from the user interface? 

If yes, the best approach would be to have any validation performed at the controller level, therefore, preventing the Save to be triggered at all if the conditions don't fit your requirements.

https://support.sugarcrm.com/Documentation/Sugar_Developer/Sugar_Developer_Guide_12.0/Cookbook/Adding_Field_Validation_to_the_Record_View/index.html

This will also prevent this validation to be triggered when the record is updated via other sources, Scheduler, API, related record saves (Etc..). That could cause Exceptions to be thrown that could impact non-related processes. 

Let me know if this helps or if your scenario does not fit my recommendations. 

Cheers, 

André

Hello Andre Serrazina
I hope this detail will make a clear understanding.
Let me know if you have any confusion here.

Thanks

Hi Dhiraj Chaudhari, 


Thanks for the extra detail. 
I still believe the best approach is to handle validation in a .js controller and prevent saving if conditions aren't met.

I did a quick test locally and seems to work fine, do you think something like this would work for you? 

custom/modules/Leads/clients/base/views/record/record.js

({
    extendsFrom: 'LeadsRecordView',

    initialize: function (options) {
        this._super('initialize', [options]);

        // Add validation task
        this.model.addValidationTask('check_recycled_lead', _.bind(this._doValidateRecycledLead, this));
    },

    _doValidateRecycledLead: function(fields, errors, callback) {
        var leadStatus = this.model.get('status');
        var dateModified = new Date(this.model.get('date_modified'));
        var currentDateTime = new Date();

        // Calculate time difference in milliseconds
        var timeDifference = currentDateTime - dateModified;
        var hoursDifference = timeDifference / (1000 * 60 * 60);

        if (leadStatus === 'Recycled' && hoursDifference < 4) {
            errors['status'] = errors['status'] || {};

                app.alert.show('message-id', {
                level: 'error',
                messages: 'Recycled leads must have a date modified older than 4 hours.',
                autoClose: false
                });

        }

        callback(null, fields, errors);
    },
})

Hi Dhiraj Chaudhari, 


Thanks for the extra detail. 
I still believe the best approach is to handle validation in a .js controller and prevent saving if conditions aren't met.

I did a quick test locally and seems to work fine, do you think something like this would work for you? 

custom/modules/Leads/clients/base/views/record/record.js

({
    extendsFrom: 'LeadsRecordView',

    initialize: function (options) {
        this._super('initialize', [options]);

        // Add validation task
        this.model.addValidationTask('check_recycled_lead', _.bind(this._doValidateRecycledLead, this));
    },

    _doValidateRecycledLead: function(fields, errors, callback) {
        var leadStatus = this.model.get('status');
        var dateModified = new Date(this.model.get('date_modified'));
        var currentDateTime = new Date();

        // Calculate time difference in milliseconds
        var timeDifference = currentDateTime - dateModified;
        var hoursDifference = timeDifference / (1000 * 60 * 60);

        if (leadStatus === 'Recycled' && hoursDifference < 4) {
            errors['status'] = errors['status'] || {};

                app.alert.show('message-id', {
                level: 'error',
                messages: 'Recycled leads must have a date modified older than 4 hours.',
                autoClose: false
                });

        }

        callback(null, fields, errors);
    },
})

Hey Andre Serrazina 

I'm pleased to share that I've successfully implemented a solution that prevents the creation of audit logs, thanks to the guidance and support I received.