$bean->emailAddress->addAddress is not working, and $sea->addAddress REMOVES all other addresses

I found another issue... in some scripts I was using:

      $sea = new SugarEmailAddress();
      $sea->addAddress($email_address,true);
      //do some checks...
      //add the email address to the Lead $bean
      $sea->save($bean->id, 'Leads');
      

While this works, it is now deleting ALL other addresses.

That is odd. Maybe you already checked it yourself in the core files but it is due to the way how the SugarEmailAddress class works. By default it does initialize the internal address array empty. When you directly add addresses to that using the addAddress function you actually adding them directly to that empty array. When you execute the save method it will then not validate what the other addresses are because it does not know yet which bean it is related to. See the following lines i the save method of that class:

if (empty($this->addresses) || $in_workflow) {
            $this->populateAddresses($id, $module, $new_addrs, $primary);
        }

If you call the populateAddressess before you add a new address to it you should be fine, I think. 

btw the code for this class hasn't been changed much between 10.0.3 and 11.0.1 atleast not for this functionality.

We jumped from 9.x to 11.x and I didn't see anything in the Release Notes for any of the versions in between (I checked them all) about such a major change in functionality. Did I miss something?

What puzzles me is that the documentation says nothing about this:

It talks about ADDING addresses not, REPLACING addresses:

https://support.sugarcrm.com/Documentation/Sugar_Developer/Sugar_Developer_Guide_11.0/Architecture/Email_Addresses/#Updating_Email_Addresses_Using_the_SugarBean

I am very confused... it was not behaving this way before, but it doesn't look like this particular file changed between v9 and v11.

FrancescaS

You didn't miss something because I can't find it either. I just did some testing myself and simply following the documentation would indeed lead to nowhere. The code that seems to work, and doesn't break anything, is as follows: (for adding addresses). But  removing doesn't seem to be working :( 

// load the bean we want to update.
$c = BeanFactory::retrieveBean('Contacts','f8c35990-453b-11eb-8f2d-34363bc92236');

// add sample email adress to this bean
$c->emailAddress->addAddress('address@sugar.crm');
// save the email relationship
$c->emailAddress->save($c->id, $c->module_dir);

You didn't miss something because I can't find it either. I just did some testing myself and simply following the documentation would indeed lead to nowhere. The code that seems to work, and doesn't break anything, is as follows: (for adding addresses). But  removing doesn't seem to be working :( 

// load the bean we want to update.
$c = BeanFactory::retrieveBean('Contacts','f8c35990-453b-11eb-8f2d-34363bc92236');

// add sample email adress to this bean
$c->emailAddress->addAddress('address@sugar.crm');
// save the email relationship
$c->emailAddress->save($c->id, $c->module_dir);

So you would set the primary when you add the address but then instead of saving the Contact bean you would specifically save the emaiLAddress on the Contact bean. 

Seems reasonable (though as established, not the documented path).

I tried to set the primary... it works, it didn't delete anything... but now I have TWO primary addresses!!

          if(!empty($contactBean)){
            //add the new address as primary
            $contactBean->emailAddress->addAddress($new_email_address, 1);
            $contactBean->emailAddress->save($contactBean->id, $contactBean->module_dir);
          }

that's odd. But from the code point of view 'correct'. I just checked the code again and htere is an function to update an existing e-mail address but you can't set the primary flag. I have to play with this a bit more to see what can be done.. 

why not save the Contact bean and use the email1 field to set the primary email address. I think this way is cleaner if you want to set the primary email or even retrieve the primary email address from Accounts, Contacts or Leads

because of this: 

"While this currently does work, these legacy email fields are deprecated and may be subject to removal in an upcoming Sugar release."

Agreed, email1 was deprecated quite a few versions ago and I removed it from all code back then.