Logichook on copying bean ?

Question

Hello everybody, 
 Is there a clean way within a before_save logichook to determine if the bean is being copied or "classically" modified ? 
 I heritated such a code : 
 if (!$arguments['isUpdate'] && preg_match('/picture_duplicateBeanId/', $_SERVER['QUERY_STRING'])){
	// $GLOBALS['log']->fatal("Copying an SLA Report :: ".$_SERVER['QUERY_STRING']);
 $split = explode('&',$_SERVER['QUERY_STRING']);
	$id = null;

 foreach($split as $k) {
 if (preg_match('/picture_duplicateBeanId/', $k)) {
 $aid = explode('=',$k);
 $id = $aid[1];
 continue;
 }
 }
} 
 The guy before me checked the query_string from the server global value, but is there a better way to do that ? 
 Best regards and nice week to all :-) 
 Enes

Enes Saridogan · Accepted Answer

Enes, 
 A couple of things here: firstly I think you should be copying related records on the after_save event not the before_save. Whilst the before_save will probably work, by definition the record does not yet actually exist. I think the related records will still be created and linked if all is OK but you might run into issues if there is a problem with the database Save. It is likely in this case that you end up with orphaned relationship records that you have no way of removing other than directly in the database. Not in itself an issue to the CRM but a waste of db storage space anyway so not the best practice. 
 Secondly, as Francesca says, what you really need is a way of differentiating between a clean "Create" event and a dirtied "Copy" event. For this I would use a boolean flag on the record that gets set in an intercept on the "Copy" button click event - it can be passed using a custom drawer open action easily enough in a parameter. For this bool flag I would be using a pseudo-field via the vardefs extensions and not create a real one in Studio otherwise you have to make sure you empty the field so that subsequent after_save events do not pick it up. As we would be in after_save, updating a "real" field like this would need SQL code or a second Save - neither of which are ideal. If you have a pseudo-field though you can set the value in the javascript (probably an initialize() function is best) and it will persist through the bean save event but not be stored anywhere leaving it empty (false) for subsequent saves. 
 Depending on what you are doing elsewhere, you may also need to distinguish between a "Copy" event and a regular "Save" event. For this you should be able to use the after_save arguments.isUpdate value ( support.sugarcrm.com/.../ ), to see if it is a new record (which a "Copy" should be) or a regular update. 
 Hopefully a couple of options in here to help you out. 
 Good luck, 
 JH.