Thread Details
  • State Suggested Answer
  • Replies 18 replies
  • Answers 1 answer
  • Subscribers 354 subscribers
  • Views 4585 views
  • Users 0 members are here
Forum Actions
Related

Validate Discount amount with Unit price in Quote line items

Vijayakumar S

Hi,

I am using sugar 7.9 version. I am trying to validate the quote line item based on the below criteria.

If Discount amount is greater than Unit price then I need to show a error message like `Total Discount amount should be less than or equal to the Unit price`.

I tried to achieve this using

'validation' => array(
'type' => 'range',
'min' => '0',
'max' => '$discount_price,
),

It's not working as expected. 

But both the fields are in currency datatype. So I am not sure How to achieve this validation.

Thanks in advance

Parents
  • 0

    You are missing a quote after $discount_price but I'm not sure that will address your problem.

    I'm not sure you can use variables like we do in sugar logic.

    All the examples I have seen of range have hardcoded numbers.

    The validations that use another field are all dates and have a compareto parameter to get the field value, for example in Meetings the date_start has the following:

          'validation' =>

          array (

            'type' => 'isbefore',

            'compareto' => 'date_end',

            'blank' => false,

          ),

    Perhaps you could put a validation on the total_amount field to check that it's greater than -1, which is greater than or equal to zero (if the discount is higher than the unit price you'll get a negative total_amount).

          'validation' =>

          array (

            'type' => 'range',

            'greaterthan' => -1,

          ),

    HTH

    FrancescaS

  • 0 in reply to Francesca Shiekh

    You will want to call the parent onSaveRowEdit if you want the row to be saved, and trigger the parent cancel if you don't want to save it.

    I've not tried this on quotes, so I don't have the code for you. Look at the original modules/ProductBundles/clients/base/views/quote-data-group-list/quote-data-group-list.js

    to see how they handle things there.

    HTH

    FrancescaS

Reply Children
  • 0 in reply to Francesca Shiekh

    Hi FrancescaS,

    Thanks for your replies.

    I cant found any files like custom/modules/ProductBundles/clients/base/views/quote-data-group-list/quote-data-group-list.js. 

    So I have copied the file from src/modules/ProductBundles/clients/base/views/quote-data-group-list/quote-data-group-list.js  and paste it in the below path

    custom/modules/ProductBundles/clients/base/views/quote-data-group-list/

    And I am trying to validate the unit price and discount price like below

    onSavingRow: function(disableCancelBtn, rowModelCid) {

          _.each(self.layout.collection.models, function(lineItem) {

              if(lineItem.cid === rowModelCid) {

                 if(parseInt(lineItem.attributes.discount_amount) > parseInt(lineItem.attributes.discount_price)) {

                      app.alert.show('closed_confirmation', {
                      level: 'error',
                       messages: app.lang.get('LBL_DISCOUNT_ERROR', 'Quotes'),
                      autoClose: true
                })

                return false;
           }

       }

    }

    I am getting the error message as expected. But after the error message the line item will automatically saved.  I cant control it from save.

    Kindly help me.

    Thanks