How to prevent multiple copies when retrieving records in after-save logic hook

Just to update, it is running on both the chosen Quote and the Quote not chosen from the subpanel rowaction.

It seems you are running such after_save LogicHook on Opportunities. From inside this Hook you fetch all related Quotes and then all related QLIs. Finally you look for a RLI related to that QLI and create a new one if it is missing. Correct?

The big deal is: On saving a RLI it will invoke Opportunity.save() which will run again you LogicHook which will create a RLI and then run again the Opportunity and so on.

I would ask in which specific scenario should that LogicHook to run?

Once you identify that specific scenario I would suggest you to turn that LogicHook into a before_save instead and then update a flag in that Opportunity, so you can evaluate that flag from insde the LogicHook, this way it will be pretty easy to avoid looping it.

Based on that specific scenario you need to figure out, you can decide whether to turn that flag so the LogicHook can be invoked accordingly.

I hope that helps you.

The customizations are happening after a javascript button is pressed. So, it would be assumed that after the button changes the saved record that the actions would take place after it saves? or is that also a weak assessment?

Here is that JS code:

({
    extendsFrom: 'SubpanelListView',
    
    initialize: function(options) {
        this._super('initialize', [options]);
        this.context.on('button:replace-quote:click', this.replaceQuote, this);
        },

    replaceQuote: function(model) {
        var self = this;
        debugger;
        self.model.attributes.id = model.attributes.id;
        app.alert.show('message-id', {
            level: 'confirmation',
            messages: 'Replace with this Quote?',
            autoClose: false,
            onConfirm: function(){
                app.alert.show('message-id', {
                    level: 'process',
                    title: 'Replacing Quote...',
                    autoClose: false
                });

                var relatedOpp   = app.data.createBean('Opportunities', {id:self.context.attributes.parentModel.id})   
                var relatedQuote = app.data.createBean('QM_Quotes_Module', {id: self.model.attributes.id});

                relatedQuote.fetch({
                    success: function(){
                        relatedOpp.fetch({
                            success: function() {
                                var rlis = relatedOpp.getRelatedCollection('revenuelineitems');
                                rlis.fetch({
                                    success:function() {
                                        _.each(rlis.models, function(rli) {
                                            var url = app.api.buildURL('RevenueLineItems/'+rli.id);
                                            app.api.call('delete',url);
                                        })
                                        relatedOpp.set('name', relatedQuote.get('description'));
                                        relatedOpp.set('opportunities_qm_quotes_module_1qm_quotes_module_idb', relatedQuote.get('id'));
                                        relatedOpp.set('account_id', relatedQuote.get('accounts_qm_quotes_module_1accounts_ida'));
                                        relatedOpp.set('date_entered', relatedQuote.get('date_entered'));
                                        relatedOpp.set('requested_on_c', relatedQuote.get('requested_on_c'));
                                        relatedOpp.save({},{
                                            success: function(){
                                                app.alert.dismissAll();
                                                app.alert.show('message-id', {
                                                level: 'success',
                                                messages: 'Quote Replaced.',
                                                autoClose: true
                                                });
                                                app.router.refresh();
                                            }
                                        })
                                    }
                                })
                            }
                        })
                    }
                })
            },
            onCancel: function(){
                app.alert.show('message-id', {
                    level: 'process',
                    messages: 'Aborted.',
                    autoClose: true
                })
            }
        })
    }
})

Once this LogicHook should be called specificaly under that scenario (clicking a button), then you may want to create a checkbox field on Opportunities and set that field as selected at js layer. You LogicHook will only run when that flag has been changed from unselected to selected, so you really need a LogicHook after_save and you must make sure your hook evaluates the attribute dataChanges. Once your LogicHook has finished creating all RLIs, you can turn of that flag and save again the Opportunity.

Cheers

Thank you!!! The combined help of you and my partner Shad Mickelberry has helped to make this a great fix for our clients. I appreciate you guys very much!